From 876d75f9ed633367b73fea69a0ad53ce007863bd Mon Sep 17 00:00:00 2001 From: sinohqb Date: Mon, 24 Aug 2026 01:37:58 +0800 Subject: [PATCH] =?UTF-8?q?refactor(intelligent-eval):=20=E5=B0=86=20=5Fge?= =?UTF-8?q?t=5Fraw=20=E6=94=B9=E4=B8=BA=E5=85=AC=E5=BC=80=E6=96=B9?= =?UTF-8?q?=E6=B3=95=20get=5Fincluding=5Fdeleted?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - 消除 lifecycle.delete_eval 对私有方法的访问 - 明确该方法用于删除幂等性检查的用途 - 符合代码规范：避免跨模块访问私有接口 --- backend/agenteval/intelligent_eval/lifecycle.py | 2 +- backend/agenteval/intelligent_eval/repository.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/backend/agenteval/intelligent_eval/lifecycle.py b/backend/agenteval/intelligent_eval/lifecycle.py index e0b12cd..ac8831e 100644 --- a/backend/agenteval/intelligent_eval/lifecycle.py +++ b/backend/agenteval/intelligent_eval/lifecycle.py @@ -202,7 +202,7 @@ def cancel(session: Session, eval_id: str) -> IntelligentEval: def delete_eval(session: Session, eval_id: str) -> IntelligentEval: """逻辑删除：completed / cancelled / failed → deleted。幂等：已删除直接返回。""" repo = IntelligentEvalRepository(session) - ev = repo._get_raw(eval_id) + ev = repo.get_including_deleted(eval_id) if ev is None: raise IntelligentEvalNotFoundError(f"intelligent eval {eval_id} not found") if ev.status is IntelligentEvalStatus.DELETED: diff --git a/backend/agenteval/intelligent_eval/repository.py b/backend/agenteval/intelligent_eval/repository.py index bb3201c..184b23d 100644 --- a/backend/agenteval/intelligent_eval/repository.py +++ b/backend/agenteval/intelligent_eval/repository.py @@ -148,8 +148,8 @@ class IntelligentEvalRepository: return None return self._from_db(db) - def _get_raw(self, eval_id: str) -> Optional[IntelligentEval]: - """包含已删除评估的原样读取（仅供 delete 幂等检查使用）。""" + def get_including_deleted(self, eval_id: str) -> Optional[IntelligentEval]: + """包含已删除评估的原样读取（供 delete 幂等检查使用）。""" db = self.session.get(IntelligentEvalDB, eval_id) return self._from_db(db) if db else None