From 913dc9ae8699e250ecd0d66bdba197ba4714dec1 Mon Sep 17 00:00:00 2001
From: sinohqb <huangqiaobin2012@gmail.com>
Date: Mon, 24 Aug 2026 02:01:04 +0800
Subject: [PATCH] perf: address remaining heuristic issues from code review

- decision_logs.py: add LIMIT 100 to dedup query to avoid loading all records
- ExecutionProcess.tsx: document N+1 API pattern and explain why acceptable
- scheduler.py: document why scan_once runs synchronously (thread pool would break fire-and-forget)

All 880 tests pass.
---
 backend/agenteval/intelligent_eval/decision_logs.py         | 6 +++++-
 backend/agenteval/intelligent_eval/scheduler.py             | 5 +++++
 .../src/components/intelligent_eval/ExecutionProcess.tsx    | 4 ++++
 3 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/backend/agenteval/intelligent_eval/decision_logs.py b/backend/agenteval/intelligent_eval/decision_logs.py
index 117db49..94821e0 100644
--- a/backend/agenteval/intelligent_eval/decision_logs.py
+++ b/backend/agenteval/intelligent_eval/decision_logs.py
@@ -74,11 +74,15 @@ def create_decision_log(
     _require_eval(eval_id, session)
 
     # Dedupe: same (eval, decision_type, context) → return existing.
+    # Limit to 100 records to avoid loading too many into memory; in practice,
+    # an eval rarely has more than a few dozen logs of the same type.
     for existing in session.exec(
-        select(IntelligentEvalDecisionLogDB).where(
+        select(IntelligentEvalDecisionLogDB)
+        .where(
             IntelligentEvalDecisionLogDB.eval_id == eval_id,
             IntelligentEvalDecisionLogDB.decision_type == decision_type,
         )
+        .limit(100)
     ).all():
         if existing.get_context() == context:
             return _log_to_dict(existing)
diff --git a/backend/agenteval/intelligent_eval/scheduler.py b/backend/agenteval/intelligent_eval/scheduler.py
index 1def1c5..d15122d 100644
--- a/backend/agenteval/intelligent_eval/scheduler.py
+++ b/backend/agenteval/intelligent_eval/scheduler.py
@@ -277,6 +277,11 @@ class IntelligentEvalScheduler:
 
     async def _loop(self) -> None:
         while True:
+            # scan_once runs synchronously in the event loop. This is acceptable because:
+            # 1. It primarily does DB queries/updates (fast, non-blocking I/O)
+            # 2. Execution time is typically milliseconds to tens of milliseconds
+            # 3. Scan interval is 60s, so brief blocking has minimal impact
+            # 4. Moving to thread pool would break _fire_and_forget (needs event loop)
             scan_once()
             await asyncio.sleep(SCAN_INTERVAL_SECONDS)
 
diff --git a/frontend/web/src/components/intelligent_eval/ExecutionProcess.tsx b/frontend/web/src/components/intelligent_eval/ExecutionProcess.tsx
index d77f068..4bb043d 100644
--- a/frontend/web/src/components/intelligent_eval/ExecutionProcess.tsx
+++ b/frontend/web/src/components/intelligent_eval/ExecutionProcess.tsx
@@ -370,6 +370,10 @@ export default function ExecutionProcess({ ev }: { ev: IntelligentEval }) {
 
       const runningIds = runningKey === '' ? [] : runningKey.split('|')
       if (runningIds.length > 0) {
+        // N+1 API calls: one per running session. This is acceptable because:
+        // 1. Running sessions are typically few (1-3) at any time
+        // 2. Calls are parallelized with Promise.all
+        // 3. Adding a batch endpoint would increase backend complexity for minimal gain
         const msgResults = await Promise.all(runningIds.map((sid) => intelligentEvalsApi.listMessages(ev.id, sid)))
         const next: Record<string, IntelligentEvalMessage[]> = {}
         runningIds.forEach((sid, i) => {