refactor(intelligent-eval): 将 _get_raw 改为公开方法 get_including_deleted
All checks were successful
CI / test (push) Successful in 3m22s
All checks were successful
CI / test (push) Successful in 3m22s
- 消除 lifecycle.delete_eval 对私有方法的访问 - 明确该方法用于删除幂等性检查的用途 - 符合代码规范:避免跨模块访问私有接口
This commit is contained in:
parent
7db75be707
commit
876d75f9ed
@ -202,7 +202,7 @@ def cancel(session: Session, eval_id: str) -> IntelligentEval:
|
||||
def delete_eval(session: Session, eval_id: str) -> IntelligentEval:
|
||||
"""逻辑删除:completed / cancelled / failed → deleted。幂等:已删除直接返回。"""
|
||||
repo = IntelligentEvalRepository(session)
|
||||
ev = repo._get_raw(eval_id)
|
||||
ev = repo.get_including_deleted(eval_id)
|
||||
if ev is None:
|
||||
raise IntelligentEvalNotFoundError(f"intelligent eval {eval_id} not found")
|
||||
if ev.status is IntelligentEvalStatus.DELETED:
|
||||
|
||||
@ -148,8 +148,8 @@ class IntelligentEvalRepository:
|
||||
return None
|
||||
return self._from_db(db)
|
||||
|
||||
def _get_raw(self, eval_id: str) -> Optional[IntelligentEval]:
|
||||
"""包含已删除评估的原样读取(仅供 delete 幂等检查使用)。"""
|
||||
def get_including_deleted(self, eval_id: str) -> Optional[IntelligentEval]:
|
||||
"""包含已删除评估的原样读取(供 delete 幂等检查使用)。"""
|
||||
db = self.session.get(IntelligentEvalDB, eval_id)
|
||||
return self._from_db(db) if db else None
|
||||
|
||||
|
||||
Loading…
Reference in New Issue
Block a user